Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On the fly JPG / HEIC conversion #53

Merged
merged 12 commits into from
Jul 26, 2023
Merged

On the fly JPG / HEIC conversion #53

merged 12 commits into from
Jul 26, 2023

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Jul 21, 2023 •
edited
Loading

With integration testing of good coverage.

@adrien-coye adrien-coye self-assigned this Jul 21, 2023
@adrien-coye adrien-coye mentioned this pull request Jul 21, 2023
Merged
@adrien-coye
fix(UTItemProviderFileRepresentation): Correct progress handlign.
05d64de 
tests(UTItemProviderFileRepresentation): Test progress of tasks to be correct
@adrien-coye adrien-coye marked this pull request as ready for review July 21, 2023 12:30
@adrien-coye adrien-coye requested a review from a team as a code owner July 21, 2023 12:30
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adrien-coye adrien-coye mentioned this pull request Jul 19, 2023
Merged
PhilippeWeidmann
PhilippeWeidmann reviewed Jul 25, 2023
View reviewed changes
Package.swift Outdated Show resolved Hide resolved
PhilippeWeidmann
PhilippeWeidmann reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for conversation to resolve before merge

@PhilippeWeidmann PhilippeWeidmann self-requested a review July 26, 2023 06:41
PhilippeWeidmann
PhilippeWeidmann approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhilippeWeidmann PhilippeWeidmann merged commit f0ff51e into master Jul 26, 2023
2 checks passed
@adrien-coye adrien-coye deleted the kDriveShareIntegration branch July 26, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees

@adrien-coye adrien-coye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrien-coye @PhilippeWeidmann